apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 20:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

cloudstack 3.0 UI - XSS - listView - editable field - fix a bug that editable field sanitized value twice.

Browse Source
This commit is contained in:
Jessica Wang 2012-03-16 11:52:58 -07:00
parent e112436510
commit 31274387fc
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ui/scripts/ui/widgets/listView.js
View File

@ -494,13 +494,13 @@
$td.addClass('editable');
// Put <td> label into a span
var value = $td.html();
$('<span></span>').html(_s(value)).appendTo($td.html(''));
var sanitizedValue = $td.html();
$('<span></span>').html(sanitizedValue).appendTo($td.html(''));
var $editArea = $('<div></div>').addClass('edit');
var $editField = $('<input />').addClass('edit').attr({
type: 'text',
value: value
value: cloudStack.sanitizeReverse(sanitizedValue)
});
var $actionButton = $('<div></div>').addClass('action');
var $saveButton = $actionButton.clone().addClass('save').attr({
@ -766,15 +766,15 @@
if (field.converter) {
content = _l(field.converter(content, dataItem));
}
$td.html(_s(content));
if (field.editable) createEditField($td).appendTo($td);
else {
var sanitizedValue = $td.html();
if (field.editable) {
$td.html(_s(content));
createEditField($td).appendTo($td);
}
else {
$td.html('');
$td.append(
$('<span></span>').html(sanitizedValue)
$('<span></span>').html(_s(content))
);
}
});