From 1c0cb19f6440047f7f04fd15225bf38f86abf72d Mon Sep 17 00:00:00 2001
From: Rohit Yadav <rohit.yadav@shapeblue.com>
Date: Sat, 8 Feb 2020 17:41:03 +0530
Subject: [PATCH] storage: fix migrate volume API usage and update
 apis.remaining

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 ui/docs/api/apis.remaining             | 17 -----------
 ui/src/views/storage/MigrateVolume.vue | 42 +++++++++++++++++---------
 2 files changed, 28 insertions(+), 31 deletions(-)

diff --git a/ui/docs/api/apis.remaining b/ui/docs/api/apis.remaining
index 57bb877ad16..c995216e7ab 100644
--- a/ui/docs/api/apis.remaining
+++ b/ui/docs/api/apis.remaining
@@ -1,27 +1,10 @@
-addResourceDetail
 createLBHealthCheckPolicy
-createManagementNetworkIpRange
-createNetworkACL
-createSnapshotFromVMSnapshot
-createStorageNetworkIpRange
-createVlanIpRange
-dedicatePublicIpRange
 deleteLBHealthCheckPolicy
-deleteManagementNetworkIpRange
-deleteNetworkACL
-deleteStorageNetworkIpRange
-deleteVlanIpRange
-findStoragePoolsForMigration
 listDeploymentPlanners
 listHostTags
 listInternalLoadBalancerVMs
 listLBHealthCheckPolicies
-listStorageNetworkIpRange
 listStorageProviders
 listStorageTags
-listVlanIpRanges
-moveNetworkAclItem
-releasePublicIpRange
 startInternalLoadBalancerVM
 stopInternalLoadBalancerVM
-updateNetworkACLItem
diff --git a/ui/src/views/storage/MigrateVolume.vue b/ui/src/views/storage/MigrateVolume.vue
index 56ecfe73cd6..fbfd694493e 100644
--- a/ui/src/views/storage/MigrateVolume.vue
+++ b/ui/src/views/storage/MigrateVolume.vue
@@ -22,7 +22,7 @@
       <p class="modal-form__label">{{ $t('storagePool') }}</p>
       <a-select v-model="selectedStoragePool" style="width: 100%;">
         <a-select-option v-for="(storagePool, index) in storagePools" :value="storagePool.id" :key="index">
-          {{ storagePool.name }}
+          {{ storagePool.name }} <span v-if="resource.virtualmachineid">{{ storagePool.suitableformigration ? '(Suitable)' : '(Not Suitable)'}}</span>
         </a-select-option>
       </a-select>
       <template v-if="this.resource.virtualmachineid">
@@ -78,24 +78,39 @@ export default {
       selectedDiskOffering: null
     }
   },
-  created () {
+  mounted () {
     this.fetchStoragePools()
     this.resource.virtualmachineid && this.fetchDiskOfferings()
   },
   methods: {
     fetchStoragePools () {
-      api('listStoragePools', {
-        zoneid: this.resource.zoneid
-      }).then(response => {
-        this.storagePools = response.liststoragepoolsresponse.storagepool
-        this.selectedStoragePool = this.storagePools[0].id
-      }).catch(error => {
-        this.$notification.error({
-          message: `Error ${error.response.status}`,
-          description: error.response.data.errorresponse.errortext
+      if (this.resource.virtualmachineid) {
+        api('findStoragePoolsForMigration', {
+          id: this.resource.id
+        }).then(response => {
+          this.storagePools = response.findstoragepoolsformigrationresponse.storagepool || []
+          this.selectedStoragePool = this.storagePools[0].id || ''
+        }).catch(error => {
+          this.$notification.error({
+            message: `Error ${error.response.status}`,
+            description: error.response.data.errorresponse.errortext
+          })
+          this.closeModal()
         })
-        this.closeModal()
-      })
+      } else {
+        api('listStoragePools', {
+          zoneid: this.resource.zoneid
+        }).then(response => {
+          this.storagePools = response.liststoragepoolsresponse.storagepool || []
+          this.selectedStoragePool = this.storagePools[0].id || ''
+        }).catch(error => {
+          this.$notification.error({
+            message: `Error ${error.response.status}`,
+            description: error.response.data.errorresponse.errortext
+          })
+          this.closeModal()
+        })
+      }
     },
     fetchDiskOfferings () {
       api('listDiskOfferings', {
@@ -180,7 +195,6 @@ export default {
     margin-top: -20px;
 
     &__label {
-      font-weight: bold;
       margin-top: 10px;
       margin-bottom: 5px;
     }