Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString()

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #438
This commit is contained in:
Rafael da Fonseca 2015-06-14 17:48:48 +02:00 committed by Rohit Yadav
parent ea7f4bd254
commit 1bd3286263

View File

@ -408,7 +408,7 @@ public class ApiResponseHelper implements ResponseGenerator {
populateAccount(resourceLimitResponse, limit.getOwnerId());
populateDomain(resourceLimitResponse, accountTemp.getDomainId());
}
resourceLimitResponse.setResourceType(Integer.valueOf(limit.getType().getOrdinal()).toString());
resourceLimitResponse.setResourceType(Integer.toString(limit.getType().getOrdinal()));
if ((limit.getType() == ResourceType.primary_storage || limit.getType() == ResourceType.secondary_storage) && limit.getMax() >= 0) {
resourceLimitResponse.setMax((long)Math.ceil((double)limit.getMax() / ResourceType.bytesToGiB));
@ -434,7 +434,7 @@ public class ApiResponseHelper implements ResponseGenerator {
populateDomain(resourceCountResponse, resourceCount.getOwnerId());
}
resourceCountResponse.setResourceType(Integer.valueOf(resourceCount.getType().getOrdinal()).toString());
resourceCountResponse.setResourceType(Integer.toString(resourceCount.getType().getOrdinal()));
resourceCountResponse.setResourceCount(resourceCount.getCount());
resourceCountResponse.setObjectName("resourcecount");
return resourceCountResponse;