apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

coverity 1315775: proper getting of networkLabel

Browse Source
This commit is contained in:
Daan Hoogland 2015-08-12 01:10:31 +02:00
parent a3ae8e0645
commit 1ab3b96594
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
engine/schema/src/com/cloud/upgrade/dao/Upgrade30xBase.java
View File

@ -34,20 +34,15 @@ public abstract class Upgrade30xBase extends LegacyDbUpgrade {
protected String getNetworkLabelFromConfig(Connection conn, String name) {
String sql = "SELECT value FROM `cloud`.`configuration` where name = ?";
String networkLabel = null;
PreparedStatement pstmt = null;
ResultSet rs = null;
try {
pstmt = conn.prepareStatement(sql);
try (PreparedStatement pstmt = conn.prepareStatement(sql);) {
pstmt.setString(1,name);
rs = pstmt.executeQuery();
if (rs.next()) {
networkLabel = rs.getString(1);
try (ResultSet rs = pstmt.executeQuery();) {
if (rs.next()) {
networkLabel = rs.getString(1);
}
}
} catch (SQLException e) {
throw new CloudRuntimeException("Unable to fetch network label from configuration", e);
} finally {
closeAutoCloseable(rs);
closeAutoCloseable(pstmt);
}
return networkLabel;
}