apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014

Browse Source 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #449
This commit is contained in:
Rafael da Fonseca 2015-06-14 21:36:11 +02:00 committed by Rohit Yadav
parent 1b79a8e1d6
commit 0dc25905d2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
View File

@ -3017,7 +3017,7 @@ public class NetworkOrchestrator extends ManagerBase implements NetworkOrchestra
}
if (!answer.getResult()) {
s_logger.warn("Unable to setup agent " + hostId + " due to " + ((answer != null) ? answer.getDetails() : "return null"));
s_logger.warn("Unable to setup agent " + hostId + " due to " + answer.getDetails() );
String msg = "Incorrect Network setup on agent, Reinitialize agent after network names are setup, details : " + answer.getDetails();
_alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_HOST, dcId, host.getPodId(), msg, msg);
throw new ConnectionException(true, msg);