apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #995 from kansal/CLOUDSTACK-9002

Browse Source 
CLOUDSTACk-9002: VM deployment is successful even when dhcp entry command fails - Fixed

Reason: The return value of the call to accept() function in the applyRules() function of BasicNetworkTopology.java was not checked for success or failure. As a result even if it fails, exception was not thrown and VM deployment went ahead without any errors.

Fix: Added the necessary checks.

* pr/995:
  CLOUDSTACk-9002: VM deployment is successful even when dhcp entry command fails - Fixed

Signed-off-by: Remi Bergsma <github@remi.nl>
This commit is contained in:
Remi Bergsma 2015-11-02 14:18:21 +01:00
commit 0c52f70b45
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
View File

@ -1244,12 +1244,16 @@ public class NetworkOrchestrator extends ManagerBase implements NetworkOrchestra
return false; return false;
} }
} }
sp.addDhcpEntry(network, profile, vmProfile, dest, context); if(!sp.addDhcpEntry(network, profile, vmProfile, dest, context)) {
return false;
}
} }
if (_networkModel.areServicesSupportedInNetwork(network.getId(), Service.UserData) if (_networkModel.areServicesSupportedInNetwork(network.getId(), Service.UserData)
&& _networkModel.isProviderSupportServiceInNetwork(network.getId(), Service.UserData, element.getProvider()) && element instanceof UserDataServiceProvider) { && _networkModel.isProviderSupportServiceInNetwork(network.getId(), Service.UserData, element.getProvider()) && element instanceof UserDataServiceProvider) {
UserDataServiceProvider sp = (UserDataServiceProvider)element; UserDataServiceProvider sp = (UserDataServiceProvider)element;
sp.addPasswordAndUserdata(network, profile, vmProfile, dest, context); if(!sp.addPasswordAndUserdata(network, profile, vmProfile, dest, context)){
return false;
}
} }
} }
return true; return true;

3
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
View File

@ -384,8 +384,7 @@ public class BasicNetworkTopology implements NetworkTopology {
} }
try { try {
ruleApplier.accept(getVisitor(), router); result = ruleApplier.accept(getVisitor(), router);
connectedRouters.add(router); connectedRouters.add(router);
} catch (final AgentUnavailableException e) { } catch (final AgentUnavailableException e) {
s_logger.warn(msg + router.getInstanceName(), e); s_logger.warn(msg + router.getInstanceName(), e);