apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

bug 13060: check for resident vms as xapi will return vms running on other hosts in the cluster

Browse Source
This commit is contained in:
Chiradeep Vittal 2012-01-17 18:33:05 -08:00
parent 46257f71d5
commit 08636d5802
1 changed files with 27 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
scripts/vm/hypervisor/xenserver/vmops
View File

@ -1052,14 +1052,26 @@ def cleanup_rules(session, args):
instance = args.get('instance') instance = args.get('instance')
if not instance: if not instance:
instance = 'VM' instance = 'VM'
resident_vms = []
try: try:
hostname = util.pread2(['/bin/bash', '-c', 'hostname']).split('\n')
if len(hostname) < 1:
raise Exception('Could not find hostname of this host')
thishost = session.xenapi.host.get_by_name_label(hostname[0])
if len(thishost) < 1:
raise Exception("Could not find host record from hostname %s of this host"%hostname[0])
hostrec = session.xenapi.host.get_record(thishost[0])
vms = hostrec.get('resident_VMs')
resident_vms = [session.xenapi.VM.get_name_label(x) for x in vms]
util.SMlog('cleanup_rules: found %s resident vms on this host %s' % (len(resident_vms)-1, hostname[0]))
chainscmd = "iptables-save | grep '^:' | awk '{print $1}' | cut -d':' -f2 | sed 's/-def/-%s/'| sed 's/-eg//' | sort|uniq" % instance chainscmd = "iptables-save | grep '^:' | awk '{print $1}' | cut -d':' -f2 | sed 's/-def/-%s/'| sed 's/-eg//' | sort|uniq" % instance
chains = util.pread2(['/bin/bash', '-c', chainscmd]).split('\n') chains = util.pread2(['/bin/bash', '-c', chainscmd]).split('\n')
vmchains = [ch for ch in chains if 1 in [ ch.startswith(c) for c in ['r-', 'i-', 's-', 'v-', 'l-']]]
util.SMlog('cleanup_rules: found %s iptables chains for vms on this host %s' % (len(vmchains), hostname[0]))
cleaned = 0 cleaned = 0
cleanup = [] cleanup = []
for chain in chains: for chain in vmchains:
if 1 in [ chain.startswith(c) for c in ['r-', 'i-', 's-', 'v-', 'l-'] ]:
vm = session.xenapi.VM.get_by_name_label(chain) vm = session.xenapi.VM.get_by_name_label(chain)
if len(vm) != 1: if len(vm) != 1:
vm = session.xenapi.VM.get_by_name_label(chain + "-untagged") vm = session.xenapi.VM.get_by_name_label(chain + "-untagged")
@ -1067,19 +1079,17 @@ def cleanup_rules(session, args):
util.SMlog("chain " + chain + " does not correspond to a vm, cleaning up") util.SMlog("chain " + chain + " does not correspond to a vm, cleaning up")
cleanup.append(chain) cleanup.append(chain)
continue continue
vm_rec = session.xenapi.VM.get_record(vm[0]) if chain not in resident_vms:
state = vm_rec.get('power_state') util.SMlog("vm " + chain + " is not running, cleaning up")
if state != 'Running' and state != 'Paused': cleanup.append(chain)
util.SMlog("vm " + vm_name + " is not running, cleaning up")
cleanup.append(vm_name)
for vm_name in cleanup: for vm_name in cleanup:
destroy_network_rules_for_vm(session, {'vmName':vm_name}) destroy_network_rules_for_vm(session, {'vmName':vm_name})
util.SMlog("Cleaned up rules for " + str(len(cleanup)) + " chains") util.SMlog("Cleaned up rules for " + str(len(cleanup)) + " chains")
return str(len(cleanup)) return str(len(cleanup))
except: except Exception, ex:
util.SMlog("Failed to cleanup rules !") util.SMlog("Failed to cleanup rules, reason= " + str(ex))
return '-1'; return '-1';
@echo @echo