From 07efd7c19de6147a2ca78fade94116efa04d1cfc Mon Sep 17 00:00:00 2001
From: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
Date: Sun, 10 Oct 2021 05:52:20 +0530
Subject: [PATCH] Updated storage type of the volume, in the volume response,
 based on the underlying storage pool. (#5560)

---
 .../com/cloud/api/query/dao/VolumeJoinDaoImpl.java    | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java b/server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
index c60e27c5352..517ac63bf07 100644
--- a/server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
+++ b/server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
@@ -213,10 +213,13 @@ public class VolumeJoinDaoImpl extends GenericDaoBaseWithTagInformation<VolumeJo
             volResponse.setStoragePoolId(volume.getPoolUuid());
             if (poolId != null) {
                 StoragePoolVO poolVO = primaryDataStoreDao.findById(poolId);
-                if (poolVO != null && poolVO.getParent() != 0L) {
-                    StoragePoolVO datastoreClusterVO = primaryDataStoreDao.findById(poolVO.getParent());
-                    volResponse.setStoragePoolName(datastoreClusterVO.getName());
-                    volResponse.setStoragePoolId(datastoreClusterVO.getUuid());
+                if (poolVO != null) {
+                    volResponse.setStorageType(poolVO.isLocal() ? ServiceOffering.StorageType.local.toString() : ServiceOffering.StorageType.shared.toString());
+                    if (poolVO.getParent() != 0L) {
+                        StoragePoolVO datastoreClusterVO = primaryDataStoreDao.findById(poolVO.getParent());
+                        volResponse.setStoragePoolName(datastoreClusterVO.getName());
+                        volResponse.setStoragePoolId(datastoreClusterVO.getUuid());
+                    }
                 }
             }
         }