From 0525e4763b7fa991535cea662ed53a41493c427c Mon Sep 17 00:00:00 2001 From: Rajani Karuturi Date: Tue, 7 Apr 2015 16:26:38 +0530 Subject: [PATCH] volume-upload: refactored some error messages --- .../storage/resource/NfsSecondaryStorageResource.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java index 7cfaa9c7f8b..1cd69fc36cd 100755 --- a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java +++ b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java @@ -2613,8 +2613,9 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S TemplateOrVolumePostUploadCommand cmd = getTemplateOrVolumePostUploadCmd(metadata); UploadEntity uploadEntity = null; if(cmd == null ){ - updateStateMapWithError(uuid,"unable decode and deserialize metadata."); - throw new InvalidParameterValueException("unable to decode and deserialize metadata"); + String errorMessage = "unable decode and deserialize metadata."; + updateStateMapWithError(uuid, errorMessage); + throw new InvalidParameterValueException(errorMessage); } else { uuid = cmd.getEntityUUID(); if (isOneTimePostUrlUsed(cmd)) { @@ -2628,8 +2629,9 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S int maxSizeInGB = Integer.valueOf(cmd.getMaxUploadSize()); int contentLengthInGB = getSizeInGB(contentLength); if (contentLengthInGB > maxSizeInGB) { - throw new InvalidParameterValueException("Maximum file upload size exceeded. Content Length received: " + contentLengthInGB + "GB. Maximum allowed size: " + - maxSizeInGB + "GB."); + String errorMessage = "Maximum file upload size exceeded. Content Length received: " + contentLengthInGB + "GB. Maximum allowed size: " + maxSizeInGB + "GB."; + updateStateMapWithError(uuid, errorMessage); + throw new InvalidParameterValueException(errorMessage); } try { String absolutePath = cmd.getAbsolutePath();