apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch '4.15' into main

Browse Source
This commit is contained in:
nicolas 2021-08-28 09:14:39 -03:00
commit 04738d7775
No known key found for this signature in database
GPG Key ID: 656E1BCC8CB54F84
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View File

@ -1416,7 +1416,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
if (!_snapshotMgr.canOperateOnVolume(volume)) { if (!_snapshotMgr.canOperateOnVolume(volume)) {
throw new InvalidParameterValueException("There are snapshot operations in progress on the volume, unable to delete it"); throw new InvalidParameterValueException("There are snapshot operations in progress on the volume, unable to delete it");
} }
if (volume.getInstanceId() != null && volume.getState() != Volume.State.Expunged) { if (volume.getInstanceId() != null && _vmInstanceDao.findById(volume.getInstanceId()) != null && volume.getState() != Volume.State.Expunged) {
throw new InvalidParameterValueException("Please specify a volume that is not attached to any VM."); throw new InvalidParameterValueException("Please specify a volume that is not attached to any VM.");
} }
if (volume.getState() == Volume.State.UploadOp) { if (volume.getState() == Volume.State.UploadOp) {
@ -1581,6 +1581,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
} }
try { try {
_volsDao.detachVolume(volume.getId());
stateTransitTo(volume, Volume.Event.RecoverRequested); stateTransitTo(volume, Volume.Event.RecoverRequested);
} catch (NoTransitionException e) { } catch (NoTransitionException e) {
s_logger.debug("Failed to recover volume" + volume.getId(), e); s_logger.debug("Failed to recover volume" + volume.getId(), e);

4
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
View File

@ -340,8 +340,8 @@ public class DiagnosticsServiceImpl extends ManagerBase implements PluggableServ
File dataDirectory = new File(dataDirectoryInSecondaryStore); File dataDirectory = new File(dataDirectoryInSecondaryStore);
boolean existsInSecondaryStore = dataDirectory.exists() || dataDirectory.mkdir(); boolean existsInSecondaryStore = dataDirectory.exists() || dataDirectory.mkdir();
if (existsInSecondaryStore) { if (existsInSecondaryStore) {
// scp from system VM to mounted sec storage directory String homeDir = System.getProperty("user.home");
File permKey = new File("/var/cloudstack/management/.ssh/id_rsa"); File permKey = new File(homeDir + "/.ssh/id_rsa");
SshHelper.scpFrom(vmSshIp, 3922, "root", permKey, dataDirectoryInSecondaryStore, diagnosticsFile); SshHelper.scpFrom(vmSshIp, 3922, "root", permKey, dataDirectoryInSecondaryStore, diagnosticsFile);
} }