From 00cdd66351e793323ed72e5c271516604908fe41 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 12:23:13 +0200 Subject: [PATCH] Fix 3 findbugs warnings OVF and VMX descriptor files should be written in UTF-8 Signed-off-by: Rohit Yadav This closes #404 --- .../com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java b/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java index ac5b4141123..ae8e860cb3a 100644 --- a/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java +++ b/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java @@ -21,7 +21,7 @@ import java.io.BufferedWriter; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.File; -import java.io.FileWriter; +import java.io.FileOutputStream; import java.io.InputStreamReader; import java.io.OutputStreamWriter; import java.net.URLEncoder; @@ -1523,7 +1523,7 @@ public class VirtualMachineMO extends BaseMO { String ovfPath = exportDir + File.separator + exportName + ".ovf"; fileNames.add(ovfPath); - FileWriter out = new FileWriter(ovfPath); + OutputStreamWriter out = new OutputStreamWriter(new FileOutputStream(ovfPath),"UTF-8"); out.write(ovfCreateDescriptorResult.getOvfDescriptor()); out.close(); @@ -1592,8 +1592,8 @@ public class VirtualMachineMO extends BaseMO { boolean replaced = false; try { - in = new BufferedReader(new InputStreamReader(new ByteArrayInputStream(vmxContent))); - out = new BufferedWriter(new OutputStreamWriter(bos)); + in = new BufferedReader(new InputStreamReader(new ByteArrayInputStream(vmxContent),"UTF-8")); + out = new BufferedWriter(new OutputStreamWriter(bos,"UTF-8")); String line; while ((line = in.readLine()) != null) { if (line.startsWith("workingDir")) {